Manually parse viewName parameter.#7574
Open
labkey-klum wants to merge 4 commits intorelease26.3-SNAPSHOTfrom
Open
Manually parse viewName parameter.#7574labkey-klum wants to merge 4 commits intorelease26.3-SNAPSHOTfrom
labkey-klum wants to merge 4 commits intorelease26.3-SNAPSHOTfrom
Conversation
cnathe
approved these changes
Apr 27, 2026
| if (value instanceof String[] strs) | ||
| _viewName = strs; | ||
| else if (value instanceof String str) | ||
| _viewName = new String[] { str }; |
Contributor
There was a problem hiding this comment.
I can't think of a way that we'd get here without it being a string or string[] but do we need an else that throws an error / or logs an error? Maybe we have presedence from other bindParameters overrides.
Contributor
Author
There was a problem hiding this comment.
I can log an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/936
Avoid automatic conversion to
String[]when the view name contains commas.